perf(core): improve applyVariants
method speed
#1790
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thanks
First of all, I want to thank you for the brilliant framework. While I interested of how it works I started looking into sources.I found that
applyVariants
method could be improved a bit, but it helps to reach 7x speed supremacy over windicss:reduce()
andreduce()
methods we can simply writereduceRight()
, as result will be the same (+ original array does not mutate)variantHandlers.slice()
instead of[...variantHandlers]
as it 2x faster (according to jsbench.me).I think there are a lot of other possibilities to improve the performance, but I think it's a nice start